-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
timeout step changes timeout for browser but not SikuliX #443
Comments
If |
Committed to master. Prior to packaged release, feature available from cutting edge version here - |
SikuliX wait_timeout also needs to be changed as part of sikuli_step() when timeout step is used. Otherwise, when present() or visible() is invoked, the SikuliX timeout setting gets reverted back to its internal variable. Also, 'casper' object should be used in displaying the error message instead of 'this'. Otherwise, for the execution context, this would be undefined and error message does not show up.
SikuliX wait_timeout also needs to be changed as part of sikuli_step() when timeout step is used. Otherwise, when present() or visible() is invoked, the SikuliX timeout setting gets reverted back to its internal variable. Also, 'casper' object should be used in displaying the error message instead of 'this'. Otherwise, for the execution context, this would be undefined and error message does not show up.
SikuliX wait_timeout also needs to be changed as part of sikuli_step() when timeout step is used. Otherwise, when present() or visible() is invoked, the SikuliX timeout setting gets reverted back to its internal variable. Also, 'casper' object should be used in displaying the error message instead of 'this'. Otherwise, for the execution context, this would be undefined and error message does not show up. Above committed PR fixes these issues. Prior to packaged release, feature available from cutting edge version here - |
In commit aisingapore@5cba169 from issue aisingapore#443 and PR aisingapore#453 the goal is to also update SikuliX integration internal timeout variable. However there is a bug introduced that makes timeout step hangs if visual automation is not used. Raising an issue to fix this bug with a PR.
In current implementation when timeout step is used, the timeout before error is shown to wait for an UI element, only changes for the web browser and not visual automation.
Users have to use vision step to invoke separately setAutoWaitTimeout(wait_timeout) in SikuliX. TagUI should ideally set browser timeout and SikuliX timeout when timeout step is called.
The text was updated successfully, but these errors were encountered: