-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisit whether single quote within XPath can be supported, yes doable - done #994
Comments
Above commit supports single quote in XPath where previously only double quote is required to send XPath to Chrome. You can download the latest copy of TagUI with this fix and unzip to overwrite your existing installation (please drag the folders under tagui\src to overwrite your existing installation) - https://github.com/kelaberetiv/TagUI/archive/master.zip In the next release, this fix will become part of the packaged zip files. Following is tested to work correctly. The fix works by detecting if an identifier provided is XPath, and if it is replace all single quotes to double quotes.
|
Check more on edge cases -
|
Found that for the old version, following does not work anyway. Thus this change won't be causing issue for a working case.
|
Closing issue, change included in latest packaged release - https://github.com/kelaberetiv/TagUI/releases/tag/v6.46.0 |
Due to human language syntax limitation, quotes in XPath are required to be double-quotes. Opening this issue to revisit.
The text was updated successfully, but these errors were encountered: