Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit whether single quote within XPath can be supported, yes doable - done #994

Closed
kensoh opened this issue Mar 31, 2021 · 4 comments
Closed
Assignees
Labels

Comments

@kensoh
Copy link
Member

kensoh commented Mar 31, 2021

Due to human language syntax limitation, quotes in XPath are required to be double-quotes. Opening this issue to revisit.

@kensoh kensoh added the query label Mar 31, 2021
@kensoh kensoh self-assigned this Mar 31, 2021
@kensoh kensoh changed the title Revisit whether single quote within XPath can be supported - to check Revisit whether single quote within XPath can be supported - to experiment Mar 31, 2021
@kensoh kensoh added feature and removed query labels May 22, 2021
@kensoh kensoh changed the title Revisit whether single quote within XPath can be supported - to experiment Revisit whether single quote within XPath can be supported, yes doable - done May 22, 2021
kensoh added a commit that referenced this issue May 22, 2021
@kensoh
Copy link
Member Author

kensoh commented May 22, 2021

Above commit supports single quote in XPath where previously only double quote is required to send XPath to Chrome.

You can download the latest copy of TagUI with this fix and unzip to overwrite your existing installation (please drag the folders under tagui\src to overwrite your existing installation) - https://github.com/kelaberetiv/TagUI/archive/master.zip

In the next release, this fix will become part of the packaged zip files. Following is tested to work correctly. The fix works by detecting if an identifier provided is XPath, and if it is replace all single quotes to double quotes.

https://google.com
type //*[@name='q'] as [clear]robotic process automation
type //*[@name="q"] as [clear]robotic process automation
type q as [clear]robotic process automation
wait

@kensoh kensoh changed the title Revisit whether single quote within XPath can be supported, yes doable - done Revisit whether single quote within XPath can be supported, yes doable - done, to review more May 24, 2021
@kensoh
Copy link
Member Author

kensoh commented May 24, 2021

Check more on edge cases -

click //*[text() = "it's here"]

@kensoh kensoh changed the title Revisit whether single quote within XPath can be supported, yes doable - done, to review more Revisit whether single quote within XPath can be supported, yes doable - done, to review May 24, 2021
@kensoh
Copy link
Member Author

kensoh commented May 24, 2021

Found that for the old version, following does not work anyway. Thus this change won't be causing issue for a working case.

click //*[text() = "it's here"]
click //*[text() = "it\'s here"]

@kensoh kensoh changed the title Revisit whether single quote within XPath can be supported, yes doable - done, to review Revisit whether single quote within XPath can be supported, yes doable - done May 24, 2021
@kensoh
Copy link
Member Author

kensoh commented Jun 18, 2021

Closing issue, change included in latest packaged release - https://github.com/kelaberetiv/TagUI/releases/tag/v6.46.0

@kensoh kensoh closed this as completed Jun 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant