generate css files in build to use with csp #4558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nightwing
force-pushed
the
csp-3
branch
2 times, most recently
from
9a7c769 to
08ef359
Compare
Codecov Report
@@ Coverage Diff @@
## master #4558 +/- ##
==========================================
+ Coverage 70.93% 71.05% +0.12%
==========================================
Files 544 546 +2
Lines 55209 55279 +70
Branches 10330 10340 +10
==========================================
+ Hits 39161 39280 +119
+ Misses 16048 15999 -49
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
iliabv
reviewed
Sep 14, 2021
Makefile.dryice.js
Outdated
|
|
||
| if (callback) | ||
| return callback(); | ||
| console.log("Finished building " + getTargetDir(options)); | ||
| } | ||
| } | ||
|
|
||
| function extractCss(options) { |
There was a problem hiding this comment.
Is that ok that we don't await on creation of theme files here, and on extractCss in general? Feels like extractCss should accept a callback to, but I don't really have much context here.
|
Hello, are there any updates for the CSP topic? |
nightwing
force-pushed
the
csp-3
branch
2 times, most recently
from
6721908 to
e1d156b
Compare
|
Hi, CSP changes are released in v1.4.13 today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #4554 for context
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.