Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jshint.js to v2.13.2 #4610

Closed
wants to merge 1 commit into from
Closed

Conversation

szediwy
Copy link

@szediwy szediwy commented Jan 6, 2022

I tried to follow the somehow cryptic instructions from issue #4609 and PR #4240. Thanks for feedback.

Upgrade jshint.js to v2.13.2

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@andrewnester
Copy link
Contributor

This version of JS hint actually does not work well, check a kitchen sink based on your commit https://raw.githack.com/szediwy/ace/master/kitchen-sink.html

Uncaught TypeError: _.each is not a function
    at module.exports./node_modules/jshint/src/messages.js.lodash (jshint.js:10771:3)
    at newRequire (jshint.js:15:30)
    at jshint.js:17:24
    at module.exports./node_modules/jshint/src/jshint.js../lex.js (jshint.js:1482:20)
    at newRequire (jshint.js:15:30)
    at outer (jshint.js:22:37)
    at Object.<anonymous> (jshint.js:25:1)
    at Object.factory (worker.js:137:41)
    at require (worker.js:66:37)
    at require (worker.js:80:19)

@nardog
Copy link

nardog commented Oct 16, 2022

Superseded by #4911, I assume.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants