Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setFontSize typing to accept number #4631

Merged
merged 1 commit into from
Feb 18, 2022
Merged

Update setFontSize typing to accept number #4631

merged 1 commit into from
Feb 18, 2022

Conversation

MasterOdin
Copy link
Contributor

Description of changes:

Per the API Docs, the parameter setFontSize should be typed as a number instead of as a string.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Feb 10, 2022

Codecov Report

Merging #4631 (13dc911) into master (8a991cc) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4631      +/-   ##
==========================================
- Coverage   71.09%   71.08%   -0.01%     
==========================================
  Files         547      547              
  Lines       55429    55429              
  Branches    10391    10391              
==========================================
- Hits        39405    39404       -1     
- Misses      16024    16025       +1     
Flag Coverage Δ
unittests 71.08% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lib/ace/editor.js 79.64% <0.00%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a991cc...13dc911. Read the comment docs.

@nightwing nightwing merged commit c34aa27 into ajaxorg:master Feb 18, 2022
@MasterOdin MasterOdin deleted the patch-1 branch February 18, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants