Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Jshint to 2.13.5 #4911

Merged
merged 2 commits into from
Aug 30, 2022
Merged

Update Jshint to 2.13.5 #4911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7328f5c
update jshint.js to 2.13.5
mkslanc Aug 26, 2022
7bbe2bc
add instruction on how to update `jshint` lib
mkslanc Aug 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5,475 changes: 3,011 additions & 2,464 deletions lib/ace/mode/javascript/jshint.js
View file
Open in desktop

Large diffs are not rendered by default.

16 changes: 15 additions & 1 deletion tool/Readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,18 @@ node add_mode.js ModeName "extension1|extension2|^FullName"

```
node tmlanguage.js ./templates/dummy.JSON-tmLanguage
```
```

# update_deps.js
To update `jshint` to new version:
1. Clone last version from https://github.com/jshint/jshint
2. Replace all `lodash` with `underscore` in requires in `jshint/src/*.js`
3. Add `_.slice = require("lodash.slice");` to `src/scope-manager.js` after `var _ = ...`
4. Add `_.clone = require("lodash.clone");` to `src/jshint.js` after `var _ = ...`
5. Add ```
"underscore": latest
"lodash.clone": "^4.5.0",
"lodash.slice": "^4.2.0"
``` to `package.json`, remove `lodash` and run `npm i`
6. Change in `ace/tool/update_deps.js` jshint path `deps.jshint.browserify.path` with your path to changed jshint
7. Run `node update_deps.js jshint`