Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to determine specific prefixes for quote insertion #5067

Merged
merged 4 commits into from
Mar 16, 2023

Conversation

mkslanc
Copy link
Contributor

@mkslanc mkslanc commented Feb 20, 2023

Issue #, if available: #5063

Description of changes:

  • add option for modes quote prefixes (separate conditions for each quote, if it's necessary)
  • fix small bug with checking leftChar for isWordAfter instead of rightChar
  • Add backtick auto insertion after word for Javascript mode

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Feb 20, 2023

Codecov Report

Base: 86.20% // Head: 86.21% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (8a077c2) compared to base (16a13ce).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 8a077c2 differs from pull request most recent head 7fb85f1. Consider uploading reports for the commit 7fb85f1 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5067   +/-   ##
=======================================
  Coverage   86.20%   86.21%           
=======================================
  Files         548      548           
  Lines       41704    41726   +22     
  Branches     6564     6565    +1     
=======================================
+ Hits        35953    35975   +22     
  Misses       5751     5751           
Flag Coverage Δ
unittests 86.21% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/mode/text.js 74.05% <ø> (ø)
src/edit_session.js 85.84% <100.00%> (ø)
src/mode/behaviour/behaviour_test.js 99.40% <100.00%> (+0.03%) ⬆️
src/mode/behaviour/cstyle.js 89.62% <100.00%> (+0.08%) ⬆️
src/mode/javascript.js 96.22% <100.00%> (+0.07%) ⬆️
src/mode/python.js 74.46% <100.00%> (+1.13%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mkslanc mkslanc force-pushed the python-quotes-behaviour branch from a6d9c21 to 6286eb5 Compare February 22, 2023 10:49
@mkslanc mkslanc force-pushed the python-quotes-behaviour branch from 6286eb5 to b331e0d Compare February 22, 2023 10:55
@mkslanc mkslanc marked this pull request as ready for review February 22, 2023 10:56
src/mode/python.js Outdated Show resolved Hide resolved
src/mode/behaviour/cstyle.js Outdated Show resolved Hide resolved
src/mode/behaviour/cstyle.js Outdated Show resolved Hide resolved
src/mode/javascript.js Outdated Show resolved Hide resolved
@mkslanc mkslanc force-pushed the python-quotes-behaviour branch from 8a077c2 to 7fb85f1 Compare February 24, 2023 12:38
@InspiredGuy InspiredGuy merged commit 34e769c into ajaxorg:master Mar 16, 2023
akoreman pushed a commit to akoreman/ace that referenced this pull request Mar 19, 2023
…rg#5067)

* add new behaviour option to determine specific prefixes for quote insertion

* make quotes check more generic; add auto quote insertion for javascript (backtick)

* change cstyle behaviours option to more suitable

* add type definition for Mode; move `$pairQuotesAfter` from options to mode property

Issue ajaxorg#5063
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants