Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile selection change #5087

Merged
merged 2 commits into from
Mar 24, 2023
Merged

Mobile selection change #5087

merged 2 commits into from
Mar 24, 2023

Conversation

nightwing
Copy link
Member

A small fix to allow moving cursor by swiping spacebar on android.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@nightwing nightwing force-pushed the mobile-selection-change branch from 2da90df to 5d65944 Compare March 12, 2023 08:52
@codecov
Copy link

codecov bot commented Mar 12, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.12 🎉

Comparison is base (d53da8e) 86.21% compared to head (99713bb) 86.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5087      +/-   ##
==========================================
+ Coverage   86.21%   86.33%   +0.12%     
==========================================
  Files         548      549       +1     
  Lines       41716    41807      +91     
  Branches     6565     6577      +12     
==========================================
+ Hits        35965    36096     +131     
+ Misses       5751     5711      -40     
Flag Coverage Δ
unittests 86.33% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/keyboard/textinput.js 77.01% <100.00%> (+1.06%) ⬆️
src/keyboard/textinput_test.js 99.59% <100.00%> (+0.05%) ⬆️

... and 10 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@InspiredGuy InspiredGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please add tests for new functionality?

src/keyboard/textinput.js Outdated Show resolved Hide resolved
src/keyboard/textinput.js Outdated Show resolved Hide resolved
@nightwing nightwing force-pushed the mobile-selection-change branch 2 times, most recently from 0bcefbf to df0e907 Compare March 17, 2023 09:47
@nightwing nightwing force-pushed the mobile-selection-change branch from df0e907 to 99713bb Compare March 17, 2023 09:52
@InspiredGuy
Copy link
Contributor

is this fix related to this issue #4178? also, is there a reason to add this functionality to android-only, is behaviour on iOS significantly different?

@nightwing
Copy link
Member Author

It is indeed related, i remembered that there was a report, but thought it got closed by the autoclose bot.
The issue with ios is that there is another code used to detect keyboard arrow presses for ipad. I think it is not needed anymore, but i was not able to test, so left it as is for now.

@InspiredGuy
Copy link
Contributor

Might be also related to #4304 - could you please confirm if this PR fixes this issue as well?

@nightwing
Copy link
Member Author

This pr does not solve that issue, which is about mouse selection handles.

@nightwing nightwing merged commit 3ce3458 into master Mar 24, 2023
@nightwing nightwing deleted the mobile-selection-change branch March 24, 2023 20:25
akoreman added a commit that referenced this pull request Jul 10, 2023
Reverts part of #5087 since it caused a regression when deleting multiple lines on android.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants