-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile selection change #5087
Mobile selection change #5087
Conversation
2da90df
to
5d65944
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #5087 +/- ##
==========================================
+ Coverage 86.21% 86.33% +0.12%
==========================================
Files 548 549 +1
Lines 41716 41807 +91
Branches 6565 6577 +12
==========================================
+ Hits 35965 36096 +131
+ Misses 5751 5711 -40
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please add tests for new functionality?
0bcefbf
to
df0e907
Compare
df0e907
to
99713bb
Compare
is this fix related to this issue #4178? also, is there a reason to add this functionality to android-only, is behaviour on iOS significantly different? |
It is indeed related, i remembered that there was a report, but thought it got closed by the autoclose bot. |
Might be also related to #4304 - could you please confirm if this PR fixes this issue as well? |
This pr does not solve that issue, which is about mouse selection handles. |
Reverts part of #5087 since it caused a regression when deleting multiple lines on android.
A small fix to allow moving cursor by swiping spacebar on android.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.