Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add updated monospace font for Windows #5091

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

InspiredGuy
Copy link
Contributor

Description of changes:

This PR adds a "Source Code Pro" font, which is available in newer windows versions. This addresses the same issue as ace-builds PR ajaxorg/ace-builds#63.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (e0d4ea9) 86.21% compared to head (4ab8741) 86.21%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5091   +/-   ##
=======================================
  Coverage   86.21%   86.21%           
=======================================
  Files         548      548           
  Lines       41718    41718           
  Branches     6566     6566           
=======================================
  Hits        35967    35967           
  Misses       5751     5751           
Flag Coverage Δ
unittests 86.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/css/editor.css.js 100.00% <ø> (ø)
src/ext/static.css.js 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@whazor whazor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@InspiredGuy InspiredGuy merged commit a981972 into ajaxorg:master Mar 15, 2023
akoreman pushed a commit to akoreman/ace that referenced this pull request Mar 19, 2023
@InspiredGuy InspiredGuy deleted the add-monospace-windows-font branch March 27, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants