fix: stop rendering the completion popup disconnected from the editor for long ghost text #5401
Conversation
akoreman
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #5401 +/- ##
==========================================
- Coverage 87.54% 86.87% -0.68%
==========================================
Files 583 583
Lines 46253 45775 -478
Branches 7003 6997 -6
==========================================
- Hits 40493 39766 -727
- Misses 5760 6009 +249
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| // In this case, we want to render the popup such that the top aligns with the bottom of the editor. | ||
| var editorContainerBottom = editor.container.getBoundingClientRect().bottom - lineHeight; | ||
| var lowestPosition = editorContainerBottom < posGhostText.top ? | ||
| {top: editorContainerBottom, left: posGhostText.left} : |
There was a problem hiding this comment.
"Added line #L238 was not covered by tests"
But you have a test that tests these changes, in particular it tests whether "Popup should start one pixel below the bottom of the editor".
Do you think it would be valuable to also test the other edge case in your test?
There was a problem hiding this comment.
you mean the edge case where the popup is within the editor and should therefore be rendered at the bottom of the ghost text?
There was a problem hiding this comment.
+1 to adding test for checking popup position at the bottom of ghost text if it is inside the editor
There was a problem hiding this comment.
added an extra test to the PR
Issue #, if available: NA
Description of changes: Currently, when ghost text extends beyond the border of the editor, the autocomplete popup can be rendered disconnected from the editor:
Screen.Recording.2023-11-26.at.22.47.35.mov
This changes this so that it will be rendered below, but still connected to, the editor at the lowest:
Screen.Recording.2023-11-26.at.22.48.38.mov
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.