Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow completers to trigger on newline characters #5519

Merged

Conversation

andredcoliveira
Copy link
Contributor

Issue #, if available:
N/A

Description of changes:
Completers may want to use newline characters for triggering suggestions. This is particularly useful when showing suggestions after typing prompts in the form of inline comments in the case of GenAI suggestions.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Pull Request Checklist:

Copy link

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

@andredcoliveira
Copy link
Contributor Author

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

Only a new method was added. No backwards incompatible changes

Copy link

One of the public type files has been updated, plase make sure there are no backwards incompatible changes done in the PR.

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 72.00000% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 86.56%. Comparing base (f493ab0) to head (a1ad3fe).

Files Patch % Lines
src/edit_session.js 0.00% 6 Missing ⚠️
src/autocomplete/util.js 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5519      +/-   ##
==========================================
- Coverage   86.57%   86.56%   -0.02%     
==========================================
  Files         588      588              
  Lines       42540    42553      +13     
  Branches     7068     7071       +3     
==========================================
+ Hits        36827    36834       +7     
- Misses       5713     5719       +6     
Flag Coverage Δ
unittests 86.56% <72.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andredcoliveira andredcoliveira merged commit 6e870fd into ajaxorg:master Mar 21, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants