Support JSON-encoded X-TITLE header from thumbnail cache #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The invidious userscript uses the old behavior already. Maybe we should version it (change /api/v1 to /api/v{version}, pass that number to function) |
|
Good point, I forgot about the whole versioned api thing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To test this pull request, follow the instructions in the wiki.
This PR allows the X-Title header received from thumbnail cache to be JSON-encoded as a way to transmit unicode characters.
This doesn't replace the raw ASCII format (yet), only decodes the header as JSON if it starts & ends with a
", then checks if a string was decoded (so we don't accidentally end up decoding an object or something like that)This is the client-side part for solving ajayyy/DeArrowThumbnailCache#3. Server-side part is in ajayyy/DeArrowThumbnailCache#9.