Add WebExt Lint as CI job #187
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspired by https://github.com/rugk/awesome-emoji-picker/blob/main/.github/workflows/webext-lint.yml As far as I see you don't run that anywhere else, so may this be a good idea?
rugk
commented
Nov 9, 2023
rugk
added a commit
to rugk/SponsorBlock
that referenced
this pull request
Nov 9, 2023
Inspired by https://github.com/rugk/awesome-emoji-picker/blob/main/.github/workflows/webext-lint.yml As far as I see you don't run that anywhere else, so may this be a good idea? Same as ajayyy/DeArrow#187
1 task
|
Warnings will need to be dealt with before merging. The only place this does get run right now is by AMO themselves when I upload a build. |
|
Workflows need approval before they can run, so one cannot even see the warnings online at GitHub at least. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by https://github.com/rugk/awesome-emoji-picker/blob/main/.github/workflows/webext-lint.yml
As far as I see you don't run that anywhere else, so may this be a good idea?
To test this pull request, follow the instructions in the wiki.