fixed the issue for powershell env variable #910
Conversation
|
lint errors can be neglected , it just rearranged the imports due to cargo fmt , which was on by default on my machine . |
|
|
||
| if ($dir.StartsWith('%') -and $dir.EndsWith('%')) { | ||
| $envVar = $dir.Trim('%') | ||
| $dir = $env:$envVar |
There was a problem hiding this comment.
I've tested on this, but your code seems to be generating errors when I load the profile on my machine.
I think you meant to write this at 33:
$dir = ${env:$envVar}
I tried to fix this too and comes up with a different approach (at #911), which might be covering more cases than your solution. Looking for reviews too.
There was a problem hiding this comment.
Upon reviewing the repository locally on my machine, I realized the fix could be related to the powershell.txt file, specifically within the __zoxide_cd function, but since I'm currently working on a Linux machine, I wasn't able to test it. I apologize for submitting the PR without proper testing.
|
As mentioned in the issue - this is a CMD.EXE feature, not a PowerShell feature. |
addressing issue #906
added the conditional check in powershell.txt