Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dns::server::defaults class fails with puppetlabs-stdlib 4.10.0 #181

Closed
ghost opened this issue Oct 24, 2016 · 0 comments
Closed

dns::server::defaults class fails with puppetlabs-stdlib 4.10.0 #181

ghost opened this issue Oct 24, 2016 · 0 comments

Comments

@ghost
Copy link

ghost commented Oct 24, 2016

In pupetlabs-stdlib version 4.10.0, the validate_re function was "improved" to include not allowing its use on any value other than a string. This breaks existing code that relied on undef being treated the same as an empty string in the previous version.

I will submit a PR to fix the failing validate_re instances.
@ghost ghost mentioned this issue Oct 25, 2016
Merged
solarkennedy added a commit that referenced this issue Oct 29, 2016
@solarkennedy
Merge pull request #182 from jearls/#181-fix-validate_re-function-calls
7be9c92 
Ensure `validate_re` calls are wrapped in `if` checks to avoid passing undef
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@solarkennedy