Control named.conf #102
Closed
Control named.conf #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <% if @osfamily == 'Debian' -%> | ||
| directory "/var/cache/bind"; | ||
| <% else -%> | ||
| directory "<%= @data_dir %>"; |
There was a problem hiding this comment.
Do we not have a data_dir on non-Debian oses? Can you make it not hard-coded in either case?
|
I submitted a new PR (#112) that fixes the spec file and addresses @solarkennedy's concerns. |
ghost
mentioned this pull request
|
Closing in favor of #112 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for controlling the content of
/etc/namedon RHEL as discussed in issue 101I have tested this on CentOS 6 and I hope I have not created any regressions.