Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated concat module version #116

Merged
merged 3 commits into from
May 28, 2015
Merged

Conversation

tedivm
Copy link
Contributor

@tedivm tedivm commented May 15, 2015

The concat module is on version 2.0.0. The vast majority of changes are internal, meant to speed the module up. On first glance there do not appear to be any changes which would cause this module issue.

Robert Hafner and others added 3 commits May 14, 2015 17:35
This was deprecated and unused in the v1 branch, and removed in the v2
branch of concat.
@tedivm tedivm changed the title Updated concat module version [WIP] Updated concat module version May 21, 2015
@tedivm
Copy link
Contributor Author

tedivm commented May 21, 2015

I'm having a bit of trouble with this- while it should work, it is not actually creating the needed fragments (in /var/lib/puppet/concat/) or the end files themselves. I am not sure if this is a bug in the DNS module or an issue with the upstream Concat module, but would appreciate anyone having a chance to look it over.

@solarkennedy
Copy link
Collaborator

Well.. the tests are still passing, which seems to suggest that the catalog works?

Can you reproduce this at the unit test level by adjusting the .fixtures.yml to reflect the new module explicitly?
https://github.com/puppetlabs/puppetlabs_spec_helper#fixtures-examples

@tedivm tedivm changed the title [WIP] Updated concat module version Updated concat module version May 26, 2015
@tedivm
Copy link
Contributor Author

tedivm commented May 26, 2015

I figured out the issue with the concat module and it was specific to my test installation.

@tedivm
Copy link
Contributor Author

tedivm commented May 26, 2015

Why was this closed? Are you not planning on supporting the newer concat module?

@solarkennedy
Copy link
Collaborator

Oh, sorry, I misinterpreted your comment.

@solarkennedy solarkennedy reopened this May 28, 2015
solarkennedy added a commit that referenced this pull request May 28, 2015
Updated concat module version
@solarkennedy solarkennedy merged commit 80fc453 into ajjahn:master May 28, 2015
@solarkennedy
Copy link
Collaborator

Thank you. Yes, we do want to keep up to date with concat.

The test pass, so if something is not working correctly, then we are missing some test coverage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants