-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated concat module version #116
Conversation
This was deprecated and unused in the v1 branch, and removed in the v2 branch of concat.
I'm having a bit of trouble with this- while it should work, it is not actually creating the needed fragments (in /var/lib/puppet/concat/) or the end files themselves. I am not sure if this is a bug in the DNS module or an issue with the upstream Concat module, but would appreciate anyone having a chance to look it over. |
Well.. the tests are still passing, which seems to suggest that the catalog works? Can you reproduce this at the unit test level by adjusting the .fixtures.yml to reflect the new module explicitly? |
I figured out the issue with the concat module and it was specific to my test installation. |
Why was this closed? Are you not planning on supporting the newer concat module? |
Oh, sorry, I misinterpreted your comment. |
Updated concat module version
Thank you. Yes, we do want to keep up to date with concat. The test pass, so if something is not working correctly, then we are missing some test coverage. |
The concat module is on version 2.0.0. The vast majority of changes are internal, meant to speed the module up. On first glance there do not appear to be any changes which would cause this module issue.