Remove invalid reference to dns::server::options::forwarder #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dns::zone class tried to reference dns::server::options::forwarder as if dns::server::options was a class rather than a defined type. Removing that check for now.
|
Removing the check against having a global forwarder and a per-zone forwarder until I can figure out how to reference an attribute from a resource defined elsewhere. |
|
I agree, this is strange and would never work. Maybe we should give up on dns::server::options being a defined type? |
solarkennedy
added a commit
that referenced
this pull request
May 31, 2015
…erver-options-forwarder Remove invalid reference to dns::server::options::forwarder
|
Why is dns::server::options a defined type? Is there ever a reason to use it more than once? |
|
I personally don't think so. I would merge in a PR to make it not so! :) |
darkfoxprime
deleted the
remove-invalid-reference-to-dns-server-options-forwarder
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dns::zone class tried to reference dns::server::options::forwarder as if dns::server::options was a class rather than a defined type. Removing that check for now.