Added initial acceptance test framework #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, needs ruby >1.87... that might be hard to support with these newer gems... |
|
@solarkennedy I haven't looked much at beaker, but I'm all for making it easier to acceptance test on different platforms. Should we keep this in it's own branch until we can work out the breaking changes with certain platforms (CentOS)? |
|
@ajjahn Na, I vote we have this on master so that when we fix the centos stuff, we can be sure we really fixed it! (and of course test for regressions) These tests involve vagrant and junk, they will not run with normal travis runs. Once I get the gemfile thing sorted, having this framework available can't "hurt" anything. |
solarkennedy
force-pushed
the
acceptance_tests
branch
2 times, most recently
from
b27e53a to
b6c9a5d
Compare
solarkennedy
force-pushed
the
acceptance_tests
branch
from
b6c9a5d to
ad6beef
Compare
|
@solarkennedy Got it. Merging... |
ajjahn
added a commit
that referenced
this pull request
Jun 9, 2015
Added initial acceptance test framework
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ajjahn This adds the beaker infrastructure so we can accept better PRs and have more confidence that they work.
These tests currently do not work on centos because of the silly way we make people have the full filename in the dns::server::options type. (eventually that will become a class and pickup the right filename from params)
I had to remove the logging section because it didn't allow bind to start up! (we are not managing the logging things properly yet)
Additionally I had to order the install->config~>service stuff so thing converged in one run so the test for idempotency passed.