Added Package require #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you. Could you tack on a spec that tests this behavior? |
|
Added Spec Tests |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to integrate this module with my puppet environment, it kept claiming that the named user wasn't present. This was because the package hadn't yet been installed.
Error: Could not set 'present' on ensure: Could not find user named at 46:/vagrant/puppet-control/modules/dns/manifests/server/default.pp
Error: Could not set 'present' on ensure: Could not find user named at 46:/vagrant/puppet-control/modules/dns/manifests/server/default.pp
Wrapped exception:
Could not find user named
Error: /Stage[main]/Dns::Server::Default/File[/etc/sysconfig/named]/ensure: change from absent to present failed: Could not set 'present' on ensure: Could not find user named at 46:/vagrant/puppet-control/modules/dns/manifests/server/default.pp
This change makes sure the the file doesn't get created before the package (and user) is there.