Add basic support for update zone-serial only on changing zone-records (updated) #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make update zone-serial only on records updates.
Support for automatic zone-serial update
Add "path =>" to exec{}
|
Tested and working as designed! Thanks! |
|
This has gotten stale :( In general I'm kinda neutral on the approach. The exec thing echoing a template seems messy, but I can't think of a better way to do it. I agree that having the puppet module converge is a really desirably thing, so I vote for worse-is-better. Can you merge master and add tests to your updated code? |
|
I will be glad to merge this feature to project. And I will try to remake this patch to make it more clear. |
|
Cool. Also, you can remove commented lines. No need to remind git of the previous code :) |
|
Obsoleted by #42 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tested it on Ubuntu 12.04 and Debian Squueze.
If you are interested in patch i am ready to work on it further.