allow port to be customized in dns::server::options #72
Conversation
| @@ -22,9 +22,9 @@ options { | |||
| <% end -%> | |||
|
|
|||
| <% if @listen_on.size == 0 then -%> | |||
There was a problem hiding this comment.
Hmm, my only problem here is this gate. You can't set the port without setting a listen_on?
There was a problem hiding this comment.
I'm ok with that I guess, as long as it is documented.
There was a problem hiding this comment.
Nope, the port can only be specified in the listen-on statement. See here: http://docstore.mik.ua/orelly/networking_2ndEd/dns/ch10_15.htm
My other thought was to allow a hash for the $listen_on argument, like so:
$listen_on = {
'10.0.0.10' => 5300
}
..since in BIND 9 you can actually set the port on a per IP basis, but there'd still need to be a $listen_on_port option for when no $listen_on addresses are defined (i.e. any).
There was a problem hiding this comment.
oh, I just looked at the official docs and there actually is a port option, separate from the listen-on option. I'll update the template to use that instead.
|
Great! |
allow port to be customized in dns::server::options
I've added a
$listen_on_portoption todns::server::optionsto allow the port to be customized. Rspec tests included.