Added in feature allowing for global allow-transfer #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| it { should contain_file('/etc/bind/named.conf.options') } | ||
| it { should contain_file('/etc/bind/named.conf.options').with_content(/192\.168\.0\.3;$/) } | ||
| it { should contain_file('/etc/bind/named.conf.options').with_content(/192\.168\.0\.4;$/) } | ||
| it { should contain_file('/etc/bind/named.conf.options').with_ensure("present") } |
There was a problem hiding this comment.
This is a tad over specified I think. The important part to me is the content
|
This is excellent! |
solarkennedy
added a commit
that referenced
this pull request
Mar 26, 2015
Added in feature allowing for global allow-transfer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would you guys find this useful? It looked like existing allow-transfer feature was for the zone level only. We have some need for global allow-transfer, so I added this in. Based the unit tests on the forwarders tests.