chore: MSRV 1.70 #162

fundon · 2024-10-05T11:14:19Z

ajrcarey · 2024-10-05T14:50:04Z

Why?

fundon · 2024-10-05T16:17:53Z

The bindgen minimum supported Rust version is 1.70.0.

ajrcarey · 2024-10-05T16:35:20Z

Thank you for taking the time over this, but I need to understand the rationale better before I approve.

bindgen is not a runtime dependency of this crate. It is only used at build-time, and then only if the "bindgen" crate feature is specifically selected, which is not the default.
bindgen is locked at 0.69.4 for this crate due to WASM builds fail on bindings generated by bindgen 0.70.0 or later #156
cargo msrv shows that the MSRV for this crate with the image feature disabled is already 1.60.0
The README for this crate establishes a MSRV of 1.60.0

So with all that in mind, please walk me through the rationale for bumping the MSRV to 1.70.0. What would be the benefit?

ajrcarey self-assigned this Oct 5, 2024

fundon force-pushed the msrv-1.70 branch from 799c4a2 to 158da0a Compare October 5, 2024 16:17

chore: MSRV 1.70

35b8636

fundon force-pushed the msrv-1.70 branch from 158da0a to 35b8636 Compare October 5, 2024 16:22

fundon closed this Oct 6, 2024

fundon deleted the msrv-1.70 branch October 6, 2024 13:02

Provide feedback