Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support elliptical mask shapes #46

Merged
merged 5 commits into from
Sep 4, 2024
Merged

Support elliptical mask shapes #46

merged 5 commits into from
Sep 4, 2024

Conversation

ajshajib
Copy link
Owner

@ajshajib ajshajib commented Sep 4, 2024

This PR adds the feature to specify elliptical masks. In the mask section of the config file, all three of "a", "b", and "angle" (see documentation of lenstronomy.Util.mask_util.mask_ellipse() for definitions) should be provided instead of "radius" for the elliptical mask to be created.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.51%. Comparing base (03e1a95) to head (c9ce44f).
Report is 17 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #46   +/-   ##
=======================================
  Coverage   99.50%   99.51%           
=======================================
  Files           8        8           
  Lines        1015     1021    +6     
=======================================
+ Hits         1010     1016    +6     
  Misses          5        5           
Files with missing lines Coverage Δ
dolphin/processor/config.py 99.50% <100.00%> (+<0.01%) ⬆️

@ajshajib ajshajib merged commit 12c5859 into master Sep 4, 2024
3 checks passed
@ajshajib ajshajib deleted the feature/elliptical_mask branch September 5, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants