fix: Provide named export alongside default export #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue does this pull request resolve?
Fixes ajv-validator/ajv#2132
Related to ajv-validator/ajv#2352.
What changes did you make?
17382ff: Created additional named export
addFormatsto the default export.f330032: Updated the documentation to use the named exports consistently.
Is there anything that requires more attention while reviewing?
The default export is the
FormatsPlugininstance, but in all examples it is referred to asaddFormats. This is a bit confusing, as there is anotheraddFormatsfunction that is used only internally and is not exported. I renamed it to_addFormatsto avoid a naming conflict.The existing default exports are untouched, so backwards compatibility is guaranteed.