Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow $ref types on additionalProperties #2225

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

theahura
Copy link

@theahura theahura commented Feb 22, 2023

What issue does this pull request resolve?
#1845
This does not fully resolve the linked issue, but it does partially resolve the bug mentioned in that issue -- namely, that $ref is only allowed in properties and nowhere else. This also conveniently solves a bug that I am currently facing. If necessary I can open a new issue

What changes did you make?
Adds { $ref: string } as a valid type for additionalProperties.

Is there anything that requires more attention while reviewing?
nope

@theahura
Copy link
Author

theahura commented Feb 22, 2023

I'll be honest, not sure at all why prettier is failing on this one line change 😬 npm run test-ci runs fine locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants