Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update parseJson() for v8 11.7.72 and newer #2356

Merged
merged 2 commits into from
Feb 16, 2024
+1 −1
Merged

fix: Update parseJson() for v8 11.7.72 and newer #2356

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f7ad4a3
fix: Update parseJson() for v8 11.7.72 and newer
egfx-notifications Dec 20, 2023
4423579
Merge branch 'master' into fix/parsejson-v8-11.7.72-and-newer
jasoniangreen Feb 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/runtime/parseJson.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
const rxParseJson = /position\s(\d+)$/
const rxParseJson = /position\s(\d+)(?: \(line \d+ column \d+\))?$/

export function parseJson(s: string, pos: number): unknown {
let endPos: number | undefined
Expand Down Expand Up @@ -129,7 +129,7 @@
while (count--) {
code <<= 4
c = s[pos]
if (c === undefined) {

Check warning on line 132 in lib/runtime/parseJson.ts

View workflow job for this annotation

GitHub Actions / build (16.x) 

Unnecessary conditional, the types have no overlap

Check warning on line 132 in lib/runtime/parseJson.ts

View workflow job for this annotation

GitHub Actions / build (18.x) 

Unnecessary conditional, the types have no overlap

Check warning on line 132 in lib/runtime/parseJson.ts

View workflow job for this annotation

GitHub Actions / build (20.x) 

Unnecessary conditional, the types have no overlap
errorMessage("unexpected end")
return undefined
}
Expand Down
Loading