Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update remaining deps except typescript #2396

Merged
merged 3 commits into from
Mar 30, 2024

Conversation

jasoniangreen
Copy link
Collaborator

@jasoniangreen jasoniangreen commented Mar 21, 2024

What issue does this pull request resolve?
Remaining dependency updates. This mainly covers ESLint which needs to deal with some new rules and config. Still waiting on access to publish ajv-formats so I can include 3.0.0 in this change too.

What changes did you make?
Updated all deps except for TypeScript which will be dealt with separately.

Is there anything that requires more attention while reviewing?
I have tweaked the config ensure we have a good coverage of good practices without having to change any code. The exception was 6 lines where I have added line level rule-disable comments for a couple of rules. In these cases I didn't want to change the code but I did want to retain the rule to pick up future violations.

At some point the disabled lines can be revisited.

@jasoniangreen jasoniangreen marked this pull request as ready for review March 30, 2024 10:07
@epoberezkin epoberezkin merged commit 32dc833 into master Mar 30, 2024
5 checks passed
@epoberezkin epoberezkin deleted the chore-upgrade-deps-20240321 branch March 30, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants