Allow search to accept namespaces and partial matches #38
Conversation
| @@ -31,14 +31,20 @@ def call | |||
| def search_descendants_matching_query | |||
| faker_descendants.each do |descendant| | |||
| methods = descendant.my_singleton_methods | |||
| matching = methods.select { |method| query_matches?(method.to_s) } | |||
| store(descendant, matching) | |||
| if query_matches_class_name?(descendant.to_s) | |||
There was a problem hiding this comment.
Really love the improvement here, I can already see a lot more results! 🙌
| context 'when no match is found' do | ||
| it 'returns an empty hash' do | ||
| query = 'foobar' | ||
| context 'when passing a full class name' do |
There was a problem hiding this comment.
Thanks for adding the test examples! 🎖
| @@ -4,25 +4,48 @@ | |||
|
|
|||
| RSpec.describe Faker::Bot::Reflectors::Search do | |||
| describe '#call' do | |||
| context 'when a match is found' do | |||
| let(:result) { described_class.new(query).call } | |||
There was a problem hiding this comment.
Interesting change here, it's definitely more reusable across the test examples. I've been trying out a different approach by defining verification logic in the test examples to mitigate the Mystery Guest test smell.
To be fair, this is a very common testing pattern in the RSpec world, so I doubt many people will have trouble making sense of it. Happy to hear your thoughts on the same. 🙂
There was a problem hiding this comment.
That's a great article! I was trying to decide if I should follow the existing pattern or avoid duplicate code, since so much of it could be shared. I'm happy to adopt the testing style you've already implemented in this app moving forward, just let me know!
This PR addresses the search features requested in #36.
New features:
_and partial searchesFaker::Kpopi_groupsmatch when searchingsimpsonsIf the class name matches, we'll return all of the class methods.
If the class name does not match, we'll check to see if any of the methods match.
Let me know any feedback, especially on the spec style 😄