Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for black config #1

Merged
merged 5 commits into from
Jun 24, 2020
Merged

Conversation

Mystic-Mirage
Copy link
Collaborator

Hi!

Now darker can use the black config.

It's ugly because it uses a dirty hack with click module. This was done for reusing purposes of the black code.

Copy link
Owner

@akaihola akaihola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Mystic-Mirage, looks like a useful addition!

I've also just reviewed #3 which adds support for a couple of Black command line arguments. I wonder if there's something both of these PRs should take into account when considering each other?

src/darker/command_line.py Outdated Show resolved Hide resolved
@akaihola
Copy link
Owner

Also please add your information to the CONTRIBUTORS.rst file!

@akaihola
Copy link
Owner

This new feature deserves a mention in the change log (CHANGES.rst). Could you add that as well?

@Mystic-Mirage
Copy link
Collaborator Author

Mystic-Mirage commented Jun 21, 2020

Changed, according to requests

Also, show version as `.dev` until the actual release.
Copy link
Owner

@akaihola akaihola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @Mystic-Mirage for this contribution!

@akaihola akaihola merged commit 9348a1c into akaihola:master Jun 24, 2020
akaihola pushed a commit that referenced this pull request Jun 26, 2020
@Mystic-Mirage Mystic-Mirage deleted the black_config branch July 10, 2020 13:01
@akaihola akaihola added this to the 1.0.0 milestone Jul 11, 2020
@akaihola akaihola added the enhancement New feature or request label Jul 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants