Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compatibility with Black >= 22.1 (Sourcery refactored) #271

Closed
wants to merge 1 commit into from

Conversation

sourcery-ai[bot]
Copy link

@sourcery-ai sourcery-ai bot commented Feb 2, 2022

Pull Request #270 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the black-22 branch, then run:

git fetch origin sourcery/black-22
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

@sourcery-ai sourcery-ai bot requested a review from akaihola February 2, 2022 20:49
@sourcery-ai sourcery-ai bot force-pushed the sourcery/black-22 branch 2 times, most recently from 35ab4c3 to aa7c5fe Compare February 6, 2022 10:52
@sourcery-ai sourcery-ai bot force-pushed the sourcery/black-22 branch 2 times, most recently from ee80e87 to e25ef2f Compare February 6, 2022 16:16
@sourcery-ai sourcery-ai bot force-pushed the sourcery/black-22 branch 3 times, most recently from e3aec84 to e87985b Compare February 6, 2022 16:54
@sourcery-ai sourcery-ai bot force-pushed the sourcery/black-22 branch from e87985b to be1d576 Compare February 6, 2022 16:57
@sourcery-ai sourcery-ai bot force-pushed the sourcery/black-22 branch from be1d576 to a0c1e7e Compare February 6, 2022 17:06
@sourcery-ai sourcery-ai bot force-pushed the sourcery/black-22 branch from a0c1e7e to 50086ff Compare February 6, 2022 17:14
@sourcery-ai sourcery-ai bot force-pushed the sourcery/black-22 branch from 50086ff to 346cc85 Compare February 6, 2022 17:17
assert result == []
assert not result
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function test_format_edited_parts_all_unchanged refactored with the following changes:

assert list(result) == []
assert not list(result)
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function test_format_edited_parts_isort_on_already_formatted refactored with the following changes:

@sourcery-ai
Copy link
Author

sourcery-ai bot commented Feb 6, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 0.02%.

Quality metrics Before After Change
Complexity 1.05 ⭐ 1.05 ⭐ 0.00
Method Length 98.61 🙂 98.52 🙂 -0.09 👍
Working memory 10.60 😞 10.60 😞 0.00
Quality 67.95% 🙂 67.97% 🙂 0.02% 👍
Other metrics Before After Change
Lines 707 707 0
Changed files Quality Before Quality After Quality Change
src/darker/tests/test_main.py 67.95% 🙂 67.97% 🙂 0.02% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
src/darker/tests/test_main.py test_main 6 ⭐ 433.96 ⛔ 25 ⛔ 30.26% 😞 Try splitting into smaller methods. Extract out complex expressions
src/darker/tests/test_main.py test_format_edited_parts 0 ⭐ 195.99 😞 15 😞 50.84% 🙂 Try splitting into smaller methods. Extract out complex expressions
src/darker/tests/test_main.py test_reformat_single_file 0 ⭐ 113 🙂 18 ⛔ 56.42% 🙂 Extract out complex expressions
src/darker/tests/test_main.py test_format_edited_parts_historical 0 ⭐ 162 😞 11 😞 59.80% 🙂 Try splitting into smaller methods. Extract out complex expressions
src/darker/tests/test_main.py test_format_edited_parts_ast_changed 0 ⭐ 149.93 😞 9 🙂 64.99% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@akaihola akaihola closed this Feb 6, 2022
@akaihola akaihola deleted the sourcery/black-22 branch February 6, 2022 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

1 participant