Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto-bump version patterns for README #63

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Conversation

akaihola
Copy link
Owner

@akaihola akaihola commented Oct 8, 2024

No description provided.

@akaihola akaihola added bug Something isn't working release Release branch or related to releasing labels Oct 8, 2024
@akaihola akaihola added this to the Graylint 2.0.1 milestone Oct 8, 2024
@akaihola akaihola self-assigned this Oct 8, 2024
@akaihola
Copy link
Owner Author

akaihola commented Oct 8, 2024

Hi @ire4ever1190,

This PR makes a correction to the regular expression pattern which was supposed to correctly update all Graylint version strings in documentation when the graylint_bump_version script is run (the script comes from darkgray-dev-tools). The v prefix was missing, and the whole rule was incorrectly indented in the YAML file.

I invited you as a collaborator on this repository, so if you're interested to review this small fix, I can assign you as reviewer for this PR. Thanks again for your contribution on #62!

@ire4ever1190
Copy link
Collaborator

Ah, sorry for not catching that in my original PR.
Yes you can assign me to the PR, happy to review

- fix YAML indentation
- add `v` prefix for pre-commit rev: fields
@akaihola
Copy link
Owner Author

akaihola commented Oct 8, 2024

Yes you can assign me to the PR, happy to review

I can do that once you accept the collaborator invitation.

@ire4ever1190
Copy link
Collaborator

Apologies, thought I accepted. Invite should be accepted now

@akaihola akaihola merged commit d84d790 into main Oct 9, 2024
38 checks passed
@akaihola akaihola deleted the version-patterns branch October 9, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working release Release branch or related to releasing
Projects
Development

Successfully merging this pull request may close these issues.

2 participants