Fix spawner not being found when under a release #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the spawner path was hardcoded at compile time, it would fail to launch from a release when the compiled code folder was no longer available (for example, within a Docker image). Fix this by resolving the path at run time.
|
@g-andrade Good catch! I don't know how I missed it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cool library!
I ran into an issue with
spawnernot being found (enoenterror) when callingExile.Process.start_link/2.The spawner path is evaluated at compile time:
exile/lib/exile/process/exec.ex
Lines 12 to 14 in 51adb42
And therefore
spawnerfails to launch from a release when the compiled code folders are no longer available (for example, from within a Docker container).Resolving the path at run time fixed the issue for me.
Info: