refactor: run golintci

Signed-off-by: Artur Troian <troian.ap@gmail.com>
akash-network · Sep 9, 2024 · a9ab9d7 · a9ab9d7
1 parent 13f27c6
commit a9ab9d7
Show file tree

Hide file tree

Showing 50 changed files with 214 additions and 299 deletions.
diff --git a/go/cli/auth_query.go b/go/cli/auth_query.go
@@ -1,6 +1,7 @@
 package cli
 
 import (
+	"encoding/hex"
 	"fmt"
 	"strconv"
 	"strings"
@@ -341,8 +342,13 @@ $ %s query tx --%s=%s <sig1_base64>,<sig2_base64...>
 						return fmt.Errorf("argument should be a tx hash")
 					}
 
+					hash, err := hex.DecodeString(args[0])
+					if err != nil {
+						return err
+					}
+
 					// If hash is given, then query the tx by hash.
-					output, err := nutils.QueryTx(ctx, cctx, args[0])
+					output, err := nutils.QueryTx(ctx, cctx, hash)
 					if err != nil {
 						return err
 					}

diff --git a/go/cli/auth_suite_test.go b/go/cli/auth_suite_test.go
@@ -267,7 +267,6 @@ func (s *AuthCLITestSuite) TestCLIQueryTxCmdByHash() {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
 		s.Run(tc.name, func() {
 			cmd := cli.GetQueryAuthTxCmd()
 			cmd.SetArgs(tc.args)
@@ -328,7 +327,6 @@ func (s *AuthCLITestSuite) TestCLIQueryTxCmdByEvents() {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
 		s.Run(tc.name, func() {
 			cmd := cli.GetQueryAuthTxCmd()
 			cmd.SetArgs(tc.args)
@@ -363,7 +361,6 @@ func (s *AuthCLITestSuite) TestCLIQueryTxsCmdByEvents() {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
 		s.Run(tc.name, func() {
 			cmd := cli.GetQueryAuthTxsByEventsCmd()
 
@@ -1133,7 +1130,6 @@ func (s *AuthCLITestSuite) TestQueryParamsCmd() {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
 		s.Run(tc.name, func() {
 			cmd := cli.GetQueryAuthParamsCmd()
 			cctx := s.cctx
@@ -1335,7 +1331,6 @@ func (s *AuthCLITestSuite) TestAuxSigner() {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
 		s.Run(tc.name, func() {
 			cmd := cli.GetTxGovSubmitLegacyProposalCmd()
 			_, err := clitestutil.ExecTestCLICmd(
@@ -1541,7 +1536,6 @@ func (s *AuthCLITestSuite) TestAuxToFeeWithTips() {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
 		s.Run(tc.name, func() {
 			cmd := cli.GetTxGovSubmitLegacyProposalCmd()
 			res, err := clitestutil.ExecTestCLICmd(
@@ -1603,7 +1597,11 @@ func (s *AuthCLITestSuite) TestAuxToFeeWithTips() {
 }
 
 func (s *AuthCLITestSuite) getBalances(cctx client.Context, addr sdk.AccAddress, denom string) math.Int {
-	resp, err := clitestutil.QueryBalancesExec(context.Background(), cctx, addr)
+	resp, err := clitestutil.QueryBalancesExec(
+		context.Background(),
+		cctx,
+		cli.TestFlags().
+			With(addr.String())...)
 	s.Require().NoError(err)
 
 	var balRes banktypes.QueryAllBalancesResponse

diff --git a/go/cli/authz_query_test.go b/go/cli/authz_query_test.go
@@ -73,8 +73,6 @@ func (s *AuthzCLITestSuite) TestQueryAuthorizations() {
 		},
 	}
 	for _, tc := range testCases {
-		tc := tc
-
 		s.Run(tc.name, func() {
 			cmd := cli.GetQueryAuthzGrantsCmd()
 			resp, err := clitestutil.ExecTestCLICmd(context.Background(), s.cctx, cmd, tc.args...)
@@ -158,8 +156,6 @@ func (s *AuthzCLITestSuite) TestQueryAuthorization() {
 		},
 	}
 	for _, tc := range testCases {
-		tc := tc
-
 		s.Run(tc.name, func() {
 			cmd := cli.GetQueryAuthzGrantsCmd()
 			_, err := clitestutil.ExecTestCLICmd(context.Background(), s.cctx, cmd, tc.args...)

diff --git a/go/cli/authz_tx_test.go b/go/cli/authz_tx_test.go
@@ -455,7 +455,6 @@ func (s *AuthzCLITestSuite) TestCmdRevokeAuthorizations() {
 		},
 	}
 	for _, tc := range testCases {
-		tc := tc
 		s.Run(tc.name, func() {
 			cmd := cli.GetTxAuthzRevokeAuthorizationCmd()
 
@@ -607,7 +606,6 @@ func (s *AuthzCLITestSuite) TestNewExecGenericAuthorized() {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
 		s.Run(tc.name, func() {
 			cmd := cli.GetTxAuthzExecAuthorizationCmd()
 
@@ -701,7 +699,6 @@ func (s *AuthzCLITestSuite) TestNewExecGrantAuthorized() {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
 		s.Run(tc.name, func() {
 			cmd := cli.GetTxAuthzExecAuthorizationCmd()
 			cctx := s.cctx

diff --git a/go/cli/bank_query.go b/go/cli/bank_query.go
@@ -226,7 +226,7 @@ To query for the total supply of a specific coin denomination use:
 			),
 		),
 		PersistentPreRunE: QueryPersistentPreRunE,
-		RunE: func(cmd *cobra.Command, args []string) error {
+		RunE: func(cmd *cobra.Command, _ []string) error {
 			ctx := cmd.Context()
 			cl := MustQueryClientFromContext(ctx)
 

diff --git a/go/cli/bank_query_test.go b/go/cli/bank_query_test.go
@@ -88,8 +88,6 @@ func (s *BankCLITestSuite) TestGetBalancesCmd() {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
-
 		s.Run(tc.name, func() {
 			cmd := cli.GetQueryBankBalancesCmd()
 			out, err := clitestutil.ExecTestCLICmd(context.Background(), tc.ctxGen(), cmd, tc.args...)
@@ -160,8 +158,6 @@ func (s *BankCLITestSuite) TestGetSpendableBalancesCmd() {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
-
 		s.Run(tc.name, func() {
 			cmd := cli.GetQueryBankSpendableBalancesCmd()
 			out, err := clitestutil.ExecTestCLICmd(context.Background(), tc.ctxGen(), cmd, tc.args...)
@@ -232,8 +228,6 @@ func (s *BankCLITestSuite) TestGetCmdDenomsMetadata() {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
-
 		s.Run(tc.name, func() {
 			cmd := cli.GetQueryBankDenomsMetadataCmd()
 			out, err := clitestutil.ExecTestCLICmd(context.Background(), tc.ctxGen(), cmd, tc.args...)
@@ -306,8 +300,6 @@ func (s *BankCLITestSuite) TestGetCmdQueryTotalSupply() {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
-
 		s.Run(tc.name, func() {
 			cmd := cli.GetQueryBankTotalSupplyCmd()
 			out, err := clitestutil.ExecTestCLICmd(context.Background(), tc.ctxGen(), cmd, tc.args...)
@@ -368,8 +360,6 @@ func (s *BankCLITestSuite) TestGetCmdQuerySendEnabled() {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
-
 		s.Run(tc.name, func() {
 			cmd := cli.GetQueryBankSendEnabledCmd()
 			out, err := clitestutil.ExecTestCLICmd(context.Background(), tc.ctxGen(), cmd, tc.args...)

diff --git a/go/cli/bank_tx_test.go b/go/cli/bank_tx_test.go
@@ -74,7 +74,6 @@ func (s *BankCLITestSuite) TestSendTxCmd() {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
 		s.Run(tc.name, func() {
 			cctx := tc.ctxGen()
 
@@ -171,7 +170,6 @@ func (s *BankCLITestSuite) TestMultiSendTxCmd() {
 	}
 
 	for _, tc := range testCases {
-		tc := tc
 		s.Run(tc.name, func() {
 			cctx := tc.ctxGen()
 

diff --git a/go/cli/cctx.go b/go/cli/cctx.go
@@ -188,7 +188,7 @@ func ReadPersistentCommandFlags(cctx sdkclient.Context, flagSet *pflag.FlagSet)
 				})))
 			}
 
-			grpcClient, err := grpc.Dial(grpcURI, dialOpts...)
+			grpcClient, err := grpc.NewClient(grpcURI, dialOpts...)
 			if err != nil {
 				return sdkclient.Context{}, err
 			}

diff --git a/go/cli/deployment_tx.go b/go/cli/deployment_tx.go
@@ -49,9 +49,9 @@ func GetTxDeploymentCmds() *cobra.Command {
 
 func GetTxDeploymentCreateCmd() *cobra.Command {
 	cmd := &cobra.Command{
-		Use:                "create [sdl-file]",
-		Short:              "Create deployment",
-		Args:               cobra.ExactArgs(1),
+		Use:               "create [sdl-file]",
+		Short:             "Create deployment",
+		Args:              cobra.ExactArgs(1),
 		PersistentPreRunE: TxPersistentPreRunE,
 		RunE: func(cmd *cobra.Command, args []string) error {
 			ctx := cmd.Context()
@@ -149,9 +149,9 @@ func GetTxDeploymentCreateCmd() *cobra.Command {
 
 func GetTxDeploymentDepositCmd() *cobra.Command {
 	cmd := &cobra.Command{
-		Use:                "deposit <amount>",
-		Short:              "Deposit funds to deployment",
-		Args:               cobra.ExactArgs(1),
+		Use:               "deposit <amount>",
+		Short:             "Deposit funds to deployment",
+		Args:              cobra.ExactArgs(1),
 		PersistentPreRunE: TxPersistentPreRunE,
 		RunE: func(cmd *cobra.Command, args []string) error {
 			ctx := cmd.Context()
@@ -197,9 +197,9 @@ func GetTxDeploymentDepositCmd() *cobra.Command {
 
 func GetTxDeploymentCloseCmd() *cobra.Command {
 	cmd := &cobra.Command{
-		Use:                "close",
-		Short:              "Close deployment",
-		Args:               cobra.ExactArgs(0),
+		Use:               "close",
+		Short:             "Close deployment",
+		Args:              cobra.ExactArgs(0),
 		PersistentPreRunE: TxPersistentPreRunE,
 		RunE: func(cmd *cobra.Command, _ []string) error {
 			ctx := cmd.Context()
@@ -229,9 +229,9 @@ func GetTxDeploymentCloseCmd() *cobra.Command {
 
 func GetTxDeploymentUpdateCmd() *cobra.Command {
 	cmd := &cobra.Command{
-		Use:                "update [sdl-file]",
-		Short:              "update deployment",
-		Args:               cobra.ExactArgs(1),
+		Use:               "update [sdl-file]",
+		Short:             "update deployment",
+		Args:              cobra.ExactArgs(1),
 		PersistentPreRunE: TxPersistentPreRunE,
 		RunE: func(cmd *cobra.Command, args []string) error {
 			ctx := cmd.Context()
@@ -317,10 +317,10 @@ func GetTxDeploymentGroupCmds() *cobra.Command {
 
 func GetTxDeploymentGroupCloseCmd() *cobra.Command {
 	cmd := &cobra.Command{
-		Use:                "close",
-		Short:              "close a Deployment's specific Group",
-		Example:            "akash tx deployment group-close --owner=[Account Address] --dseq=[uint64] --gseq=[uint32]",
-		Args:               cobra.ExactArgs(0),
+		Use:               "close",
+		Short:             "close a Deployment's specific Group",
+		Example:           "akash tx deployment group-close --owner=[Account Address] --dseq=[uint64] --gseq=[uint32]",
+		Args:              cobra.ExactArgs(0),
 		PersistentPreRunE: TxPersistentPreRunE,
 		RunE: func(cmd *cobra.Command, _ []string) error {
 			ctx := cmd.Context()
@@ -357,10 +357,10 @@ func GetTxDeploymentGroupCloseCmd() *cobra.Command {
 
 func GetDeploymentGroupPauseCmd() *cobra.Command {
 	cmd := &cobra.Command{
-		Use:                "pause",
-		Short:              "pause a Deployment's specific Group",
-		Example:            "akash tx deployment group pause --owner=[Account Address] --dseq=[uint64] --gseq=[uint32]",
-		Args:               cobra.ExactArgs(0),
+		Use:               "pause",
+		Short:             "pause a Deployment's specific Group",
+		Example:           "akash tx deployment group pause --owner=[Account Address] --dseq=[uint64] --gseq=[uint32]",
+		Args:              cobra.ExactArgs(0),
 		PersistentPreRunE: TxPersistentPreRunE,
 		RunE: func(cmd *cobra.Command, _ []string) error {
 			ctx := cmd.Context()
@@ -397,10 +397,10 @@ func GetDeploymentGroupPauseCmd() *cobra.Command {
 
 func GetDeploymentGroupStartCmd() *cobra.Command {
 	cmd := &cobra.Command{
-		Use:                "start",
-		Short:              "start a Deployment's specific Group",
-		Example:            "akash tx deployment group pause --owner=[Account Address] --dseq=[uint64] --gseq=[uint32]",
-		Args:               cobra.ExactArgs(0),
+		Use:               "start",
+		Short:             "start a Deployment's specific Group",
+		Example:           "akash tx deployment group pause --owner=[Account Address] --dseq=[uint64] --gseq=[uint32]",
+		Args:              cobra.ExactArgs(0),
 		PersistentPreRunE: TxPersistentPreRunE,
 		RunE: func(cmd *cobra.Command, _ []string) error {
 			ctx := cmd.Context()
@@ -462,7 +462,7 @@ Examples:
  $ akash tx %s authz grant akash1skjw.. 50akt --from=akash1skl.. --expiration=1661020200
 	`, dv1.ModuleName, dv1.ModuleName),
 		),
-		Args:               cobra.ExactArgs(2),
+		Args:              cobra.ExactArgs(2),
 		PersistentPreRunE: TxPersistentPreRunE,
 		RunE: func(cmd *cobra.Command, args []string) error {
 			ctx := cmd.Context()
@@ -522,7 +522,7 @@ Example:
  $ akash tx %s authz revoke akash1skj.. --from=akash1skj..
 			`, dv1.ModuleName),
 		),
-		Args:               cobra.ExactArgs(1),
+		Args:              cobra.ExactArgs(1),
 		PersistentPreRunE: TxPersistentPreRunE,
 		RunE: func(cmd *cobra.Command, args []string) error {
 			ctx := cmd.Context()

diff --git a/go/cli/distribution_query.go b/go/cli/distribution_query.go
@@ -340,7 +340,7 @@ $ %s query distribution community-pool
 			),
 		),
 		PersistentPreRunE: QueryPersistentPreRunE,
-		RunE: func(cmd *cobra.Command, args []string) error {
+		RunE: func(cmd *cobra.Command, _ []string) error {
 			ctx := cmd.Context()
 
 			cl := MustQueryClientFromContext(ctx)

diff --git a/go/cli/distribution_tx.go b/go/cli/distribution_tx.go
@@ -51,7 +51,12 @@ func getTxDistributionCmd() *cobra.Command {
 type distrGenerateOrBroadcastFunc func(context.Context, []sdk.Msg, ...cclient.BroadcastOption) (interface{}, error)
 
 func newSplitAndApply(
-	genOrBroadcastFn distrGenerateOrBroadcastFunc, ctx context.Context, msgs []sdk.Msg, chunkSize int, opts ...cclient.BroadcastOption) error {
+	ctx context.Context,
+	genOrBroadcastFn distrGenerateOrBroadcastFunc,
+	msgs []sdk.Msg,
+	chunkSize int,
+	opts ...cclient.BroadcastOption,
+) error {
 	if chunkSize == 0 {
 		if _, err := genOrBroadcastFn(ctx, msgs, opts...); err != nil {
 			return err
@@ -176,7 +181,7 @@ $ %[1]s tx distribution withdraw-all-rewards --from mykey
 
 			chunkSize, _ := cmd.Flags().GetInt(FlagMaxMessagesPerTx)
 
-			return newSplitAndApply(cl.Tx().BroadcastMsgs, ctx, msgs, chunkSize)
+			return newSplitAndApply(ctx, cl.Tx().BroadcastMsgs, msgs, chunkSize)
 		},
 	}
 
@@ -287,7 +292,7 @@ $ %s tx distribution withdraw-tokenize-share-rewards --from mykey
 				version.AppName,
 			),
 		),
-		RunE: func(cmd *cobra.Command, args []string) error {
+		RunE: func(cmd *cobra.Command, _ []string) error {
 			ctx := cmd.Context()
 			cl := MustClientFromContext(ctx)
 			cctx := cl.ClientContext()

diff --git a/go/cli/flags/client.go b/go/cli/flags/client.go
@@ -10,7 +10,6 @@ import (
 )
 
 // ClientOptionsFromFlags reads client options from cli flag set.
-//
 func ClientOptionsFromFlags(flagSet *pflag.FlagSet) ([]cltypes.ClientOption, error) {
 	opts := make([]cltypes.ClientOption, 0)
 

diff --git a/go/cli/genesis_genaccount.go b/go/cli/genesis_genaccount.go
@@ -15,10 +15,6 @@ import (
 	cflags "pkg.akt.dev/go/cli/flags"
 )
 
-const (
-
-)
-
 // GetGenesisAddAccountCmd returns add-genesis-account cobra Command.
 // This command is provided as a default, applications are expected to provide their own command if custom genesis accounts are needed.
 func GetGenesisAddAccountCmd(defaultNodeHome string) *cobra.Command {

diff --git a/go/cli/genesis_genaccount_test.go b/go/cli/genesis_genaccount_test.go
@@ -64,7 +64,6 @@ func TestAddGenesisAccountCmd(t *testing.T) {
 	}
 
 	for _, tc := range tests {
-		tc := tc
 		t.Run(tc.name, func(t *testing.T) {
 			home := t.TempDir()
 			logger := log.NewNopLogger()

diff --git a/go/cli/genesis_gentx_test.go b/go/cli/genesis_gentx_test.go
@@ -65,8 +65,6 @@ func (s *GenesisCLITestSuite) TestGenTxCmd() {
 	}
 
 	for _, tc := range tests {
-		tc := tc
-
 		dir := s.T().TempDir()
 		genTxFile := filepath.Join(dir, "myTx")