Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(go): backport reflection interceptor #117

Merged
merged 1 commit into from
Jan 30, 2024
Merged

Conversation

troian
Copy link
Member

@troian troian commented Jan 30, 2024

certain proto files register themselves in a way
but are imported by other files in a different way. It is not super important when using codegen file, but it make developing workflow pain in the fingers, as reflection with tools like grpcurl does not work

@troian troian requested a review from a team as a code owner January 30, 2024 03:45
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

Attention: 364 lines in your changes are missing coverage. Please review.

Comparison is base (32e2e1f) 3.48% compared to head (7c9dd63) 3.51%.

❗ Current head 7c9dd63 differs from pull request most recent head 2622e81. Consider uploading reports for the commit 2622e81 to get more accurate results

Files Patch % Lines
go/grpc/gogoreflection/serverreflection.go 2.56% 300 Missing and 4 partials ⚠️
go/grpc/gogoreflection/fix_registration.go 31.81% 53 Missing and 7 partials ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main    #117      +/-   ##
========================================
+ Coverage   3.48%   3.51%   +0.02%     
========================================
  Files        295     297       +2     
  Lines      96895   97295     +400     
========================================
+ Hits        3380    3416      +36     
- Misses     93346   93699     +353     
- Partials     169     180      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

certain proto files register themselves in a way
but are imported by other files in a different way.
It is not super important when using codegen file,
but it make developing workflow pain in the fingers,
as reflection with tools like grpcurl does not work

Signed-off-by: Artur Troian <troian.ap@gmail.com>
@troian troian merged commit d973e75 into main Jan 30, 2024
4 checks passed
@troian troian deleted the reflection-intercept branch January 30, 2024 03:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant