Skip to content

Commit

Permalink
Merge pull request #294 from akashic-games/fix-tab-index
Browse files Browse the repository at this point in the history
fix: replace tabindex to tabIndex
  • Loading branch information
yu-ogi authored Oct 18, 2023
2 parents 1bcaeff + ed3d9e4 commit d4a9b9b
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 9 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# CHANGELOG

## 2.8.2
* `Platform#getTabindex()``Platform#getTabIndex()` に変更
* `Platform#setTabindex()``Platform#setTabIndex()` に変更

## 2.8.1
* `Platform#setTabindex()` を追加
* `InputHandler``view` の Element に `tabindex: 0` をデフォルトで付与するように
Expand Down
4 changes: 2 additions & 2 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@akashic/pdi-browser",
"version": "2.8.1",
"version": "2.8.2",
"description": "An akashic-pdi implementation for Web browsers",
"main": "index.js",
"typings": "lib/full/index.d.ts",
Expand Down
4 changes: 2 additions & 2 deletions src/ContainerController.ts
Original file line number Diff line number Diff line change
Expand Up @@ -99,8 +99,8 @@ export class ContainerController {
}
}

setTabindex(tabindex: string): void {
this.inputHandlerLayer.setViewTabindex(tabindex);
setTabIndex(tabIndex: string): void {
this.inputHandlerLayer.setViewTabIndex(tabIndex);
}

private _loadView(): void {
Expand Down
4 changes: 2 additions & 2 deletions src/InputHandlerLayer.ts
Original file line number Diff line number Diff line change
Expand Up @@ -67,9 +67,9 @@ export class InputHandlerLayer {
view.style.height = size.height + "px";
}

setViewTabindex(tabindex: string): void {
setViewTabIndex(tabIndex: string): void {
const view = this.view;
view.setAttribute("tabindex", tabindex);
view.setAttribute("tabindex", tabIndex);
}

private _createInputView(width: number, height: number): HTMLDivElement {
Expand Down
4 changes: 2 additions & 2 deletions src/Platform.ts
Original file line number Diff line number Diff line change
Expand Up @@ -181,8 +181,8 @@ export class Platform implements pdi.Platform {
return this._audioManager.getMasterVolume();
}

setTabindex(tabindex: string): void {
this.containerController.setTabindex(tabindex);
setTabIndex(tabIndex: string): void {
this.containerController.setTabIndex(tabIndex);
}

destroy(): void {
Expand Down

0 comments on commit d4a9b9b

Please sign in to comment.