Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overwriting linker flags #610

Merged
merged 1 commit into from
May 3, 2022
Merged

Fix overwriting linker flags #610

merged 1 commit into from
May 3, 2022

Conversation

Thomas1664
Copy link
Contributor

You were overwriting CMAKE_SHARED_LINKER_FLAGS without caring about already set flags. This causes builds on UWP to fail.

@Thomas1664 Thomas1664 mentioned this pull request Apr 28, 2022
Merged
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.234% when pulling fe6e8ee on Thomas1664:master into addeeef on akheron:master.

@akheron akheron merged commit 128e9c5 into akheron:master May 3, 2022
@akheron
Copy link
Owner

akheron commented May 3, 2022

Merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Thomas1664 @coveralls @akheron