Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add an open_qf_command setting #63

Merged
merged 3 commits into from
Aug 21, 2023
Merged

feat: Add an open_qf_command setting #63

merged 3 commits into from
Aug 21, 2023

Conversation

MariaSolOs
Copy link
Contributor

Closes #61

Copy link
Owner

@akinsho akinsho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MariaSolOs this looks good to me. I've just added one comment about changing the name to something more generic that doesn't reference the qf since now technically people could use this with telescope or whatever else they want

README.md Outdated Show resolved Hide resolved
@MariaSolOs
Copy link
Contributor Author

btw, when testing this I discovered #64.

@akinsho
Copy link
Owner

akinsho commented Aug 21, 2023

Thanks for raising the issue @MariaSolOs, good to have it tracked.

@akinsho akinsho merged commit 1e74b7d into akinsho:main Aug 21, 2023
3 checks passed
@MariaSolOs MariaSolOs deleted the open-qf branch August 21, 2023 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Expose a way to use Trouble with GitConflictListQf
2 participants