Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to improve the plugin's behavior when running inside multisite environments.
Problem
The Friends plugin was designed for allowing unrelated sites across the web to communicate with each other and establish authentication against each other. They communicate via REST API and represent each other with locally created users. The content for the other sites is downloaded via feeds and assigned to these representative users with a custom post type
friend_post_cache
.While this generally works in a multisite context, there are a few things that don't fit the environment well:
Solution
This PR addresses the above in the following ways:
This has been hard to represent in unit tests but those covering the general behavior still work. I've done a lot of manual testing to ensure that this doesn't break existing flows.
Refs #96, #99.