Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies, apply scalafmt, and resolve warnings #57

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

mliarakos
Copy link
Contributor

@mliarakos mliarakos commented Jan 28, 2022

  • Update to latest SBT 1.3
    • I'm not familiar with SBT plugins, so I didn't know if updating more would break something
  • Updated Scala and dependencies to latest compatible with Scala.js 1.0.1
    • I can update Scala.js too if you are fine with the compatibility break
  • Ported and applied akka scalafmt settings
    • I figured the akka settings were the best baseline, but I can change/customize
  • Resolved compiler and style warnings
  • Deprecated getMillisDuration and getNanosDuration since they belong to an Akka helper
    • I'm also wokring on an Akka.js PR that will re-introduce them there

@andreaTP
Copy link
Member

I'm not familiar with SBT plugins, so I didn't know if updating more would break something

There are scripted tests for the sbt plugin: https://github.com/akka-js/shocon/blob/master/travis/testSbtPlugin.sh

I can update Scala.js too if you are fine with the compatibility break

Totally fine if this is the direction the community is taking!

I figured the akka settings were the best baseline, but I can change/customize

the automatic formatting in this repo have always been broken ... I'm happy with anything that is automated

Overall thanks a lot!

@mliarakos would you consider stepping up as a maintainer in the akka-js org?

@mliarakos
Copy link
Contributor Author

There are scripted tests for the sbt plugin: https://github.com/akka-js/shocon/blob/master/travis/testSbtPlugin.sh

I was able to move everything to SBT 1.4.9 with tests passing. I didn't go beyond SBT 1.4.x to avoid dealing with versionScheme introduced in SBT 1.5.0 for the time being.

Totally fine if this is the direction the community is taking!

Bumped Scala.js to 1.8.0. Reviewing usage on Maven Central, it looks like many projects are moving Scala.js forward over time. In addition, this is all for akka-js/akka.js#129, which needs to update to Scala.js 1.8.0 anyway.

@mliarakos would you consider stepping up as a maintainer in the akka-js org?

I really appreciate the offer, but I don't have the time for the comitment right now. I'l let you know if that changes in the future.

@mliarakos mliarakos marked this pull request as ready for review February 27, 2022 15:51
@mliarakos
Copy link
Contributor Author

Because of the big Scala.js bump, I bumped the library version to 1.1.0 rather than 1.0.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants