Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Alpakka Cassandra #736

Merged
merged 2 commits into from
Mar 12, 2020
Merged

Use Alpakka Cassandra #736

merged 2 commits into from
Mar 12, 2020

Conversation

ennru
Copy link
Member

@ennru ennru commented Mar 12, 2020

  • Drop the session sub-project and depend on the Alpakka Cassandra snapshot instead.

  • Fix the snapshot publishing to Bintray and update the docs about it.

Solves #390
References akka/alpakka#1213

@ennru ennru requested a review from patriknw March 12, 2020 09:03
Copy link
Member

@patriknw patriknw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some nitpick


## Project Info

@@project-info{ projectId="core" }

## Dependencies

This plugin requires **Akka 2.6** and is built against Akka $akka.version$.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or

This plugin requires **Akka $akka.version$** or later.

since users don't understand that they can use later version than the build version.

@@ -1,25 +1,19 @@
ThisBuild / resolvers += "Akka Snapshots".at("https://repo.akka.io/snapshots/")
// Alpakka Snapshots
ThisBuild / resolvers += Resolver.bintrayRepo("akka", "snapshots")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIXME that this should be removed

@ennru ennru merged commit 7ee933a into akka:master Mar 12, 2020
@ennru ennru deleted the alpakka-session branch March 12, 2020 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants