-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump: Netty 4.1.89 due to CVE-2022-41915 #355
Conversation
project/Dependencies.scala
Outdated
// FIXME remove this when r2dbc-postgresql includes a later Netty version | ||
val nettyHandlerProxy = "io.netty" % "netty-handler-proxy" % NettyVersion | ||
val nettyResolverDns = "io.netty" % "netty-resolver-dns" % NettyVersion | ||
val nettyResolverDnsMacos = "io.netty" % "netty-resolver-dns-macos" % NettyVersion classifier "osx-x86_64" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the dns-macos classifier doesn't work for me, still 4.1.84.Final according to dependencyTree
additionally, might also need osx-aarch_64
for M1
I'm not sure it will work to override the transitive dependency with classifier?
project/Dependencies.scala
Outdated
// FIXME remove this when r2dbc-postgresql includes a later Netty version | ||
val nettyHandlerProxy = "io.netty" % "netty-handler-proxy" % NettyVersion | ||
val nettyResolverDns = "io.netty" % "netty-resolver-dns" % NettyVersion | ||
val nettyResolverDnsMacos = "io.netty" % "netty-resolver-dns-native-macos" % NettyVersion classifier "osx-x86_64" classifier "osx-aarch_64" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had problem with this first, but I had not used the right artifact name. Seems like the build is not failing when using classifier. Anyway, this works, and generates pom:
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-resolver-dns-native-macos</artifactId>
<version>4.1.89.Final</version>
<classifier>osx-aarch_64</classifier>
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-resolver-dns-native-macos</artifactId>
<version>4.1.89.Final</version>
<classifier>osx-x86_64</classifier>
</dependency>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran tests on m1 against Postgres, seems to work fine! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for verifying that
Also PR upstream: pgjdbc/r2dbc-postgresql#584 |
No description provided.