bump: Netty 4.1.89 due to CVE-2022-41915 #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patriknw
commented
Feb 14, 2023
project/Dependencies.scala
Outdated
| // FIXME remove this when r2dbc-postgresql includes a later Netty version | ||
| val nettyHandlerProxy = "io.netty" % "netty-handler-proxy" % NettyVersion | ||
| val nettyResolverDns = "io.netty" % "netty-resolver-dns" % NettyVersion | ||
| val nettyResolverDnsMacos = "io.netty" % "netty-resolver-dns-macos" % NettyVersion classifier "osx-x86_64" |
There was a problem hiding this comment.
the dns-macos classifier doesn't work for me, still 4.1.84.Final according to dependencyTree
additionally, might also need osx-aarch_64 for M1
I'm not sure it will work to override the transitive dependency with classifier?
patriknw
commented
Feb 15, 2023
project/Dependencies.scala
Outdated
| // FIXME remove this when r2dbc-postgresql includes a later Netty version | ||
| val nettyHandlerProxy = "io.netty" % "netty-handler-proxy" % NettyVersion | ||
| val nettyResolverDns = "io.netty" % "netty-resolver-dns" % NettyVersion | ||
| val nettyResolverDnsMacos = "io.netty" % "netty-resolver-dns-native-macos" % NettyVersion classifier "osx-x86_64" classifier "osx-aarch_64" |
There was a problem hiding this comment.
I had problem with this first, but I had not used the right artifact name. Seems like the build is not failing when using classifier. Anyway, this works, and generates pom:
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-resolver-dns-native-macos</artifactId>
<version>4.1.89.Final</version>
<classifier>osx-aarch_64</classifier>
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-resolver-dns-native-macos</artifactId>
<version>4.1.89.Final</version>
<classifier>osx-x86_64</classifier>
</dependency>
There was a problem hiding this comment.
I ran tests on m1 against Postgres, seems to work fine! 👍
There was a problem hiding this comment.
thanks for verifying that
johanandren
approved these changes
Feb 15, 2023
|
Also PR upstream: pgjdbc/r2dbc-postgresql#584 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.