-
Notifications
You must be signed in to change notification settings - Fork 440
Alpakka Kafka External Sharding Allocation support #192
Conversation
9f54f0c
to
f53f3b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...ample-kafka-to-sharding-scala/processor/src/main/scala/akka/kafka/KafkaClusterSharding.scala
Outdated
Show resolved
Hide resolved
...ample-kafka-to-sharding-scala/processor/src/main/scala/akka/kafka/KafkaClusterSharding.scala
Outdated
Show resolved
Hide resolved
...ample-kafka-to-sharding-scala/processor/src/main/scala/akka/kafka/KafkaClusterSharding.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than small suggestions and the 500 Internal Server Error
when trying the sample app it all LGTM
...ample-kafka-to-sharding-scala/processor/src/main/scala/akka/kafka/KafkaClusterSharding.scala
Outdated
Show resolved
Hide resolved
...ample-kafka-to-sharding-scala/processor/src/main/scala/akka/kafka/KafkaClusterSharding.scala
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good
...ample-kafka-to-sharding-scala/processor/src/main/scala/akka/kafka/KafkaClusterSharding.scala
Outdated
Show resolved
Hide resolved
...mple-kafka-to-sharding-scala/processor/src/main/scala/sample/sharding/kafka/UserEvents.scala
Outdated
Show resolved
Hide resolved
...mple-kafka-to-sharding-scala/processor/src/main/scala/sample/sharding/kafka/UserEvents.scala
Outdated
Show resolved
Hide resolved
I've published a public alpakka kafka snapshot. Should we wait for an alpakka-kafka release before merging? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I'll fix the conflict |
Thanks @chbatey! |
Enhancements to the sample and a proposal of what to send upstream to Alpakka Kafka/
akka.kafka
namespace.Introduce Alpakka Kafka API for getting the cluster sharding message extractor and group rebalance listener (Moved to Alpakka Kafka Kafka cluster sharding support with external sharding allocation alpakka-kafka#1067akka.kafka
namespace)DefaultPartitioner
from Apache Kafka uses