Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AWS S3: prepare docker image to run Minio tests #938

Closed
ennru opened this issue May 8, 2018 · 3 comments
Closed

AWS S3: prepare docker image to run Minio tests #938

ennru opened this issue May 8, 2018 · 3 comments
Labels
p:aws-s3
Milestone
1.0-M2

Comments

@ennru
Copy link
Member

ennru commented May 8, 2018

The AWS S3 connector code even contains integration tests that can run against Minio.
We could prepare a docker image and run those tests in the CI cycle, as well.
Instructions to run it are found in the MinioS3IntegrationSpec comment.
@ennru ennru added the p:aws-s3 label May 8, 2018
@sfali sfali mentioned this issue May 22, 2018
Merged
@ennru
Copy link
Member Author

ennru commented Jun 5, 2018

@sfali Would be great if you could PR the Docker config you used with #951 and propose a way to add and remove buckets for testing.

@sfali
Copy link
Contributor

sfali commented Jun 5, 2018

Sure, I will.

sfali pushed a commit to sfali/alpakka that referenced this issue Jun 7, 2018
createBucket request, akka#938
49c9dc2 
    * populate createBucket request
    * test cases createBucket
sfali pushed a commit to sfali/alpakka that referenced this issue Jun 7, 2018
createBucket function for integration testing pupose only, akka#938
e023b4f
sfali pushed a commit to sfali/alpakka that referenced this issue Jun 7, 2018
docker compose file to run minio servers, akka#938
ca854de
sfali pushed a commit to sfali/alpakka that referenced this issue Jun 7, 2018
Following changes: akka#938
5a339d2 
   * rename createBucket to createBucketRequest
   * internal function to create bucket request
   * deleteBucket request
sfali pushed a commit to sfali/alpakka that referenced this issue Jun 7, 2018
delete bucket function, akka#938
6a6cc12
sfali pushed a commit to sfali/alpakka that referenced this issue Jun 10, 2018
create and delete bucket on every run, akka#938
a730f04
sfali pushed a commit to sfali/alpakka that referenced this issue Jun 10, 2018
Integrating integration in tests in CI, akka#938
586f15c
sfali pushed a commit to sfali/alpakka that referenced this issue Jun 10, 2018
add minio docker command to main docker-compose file, akka#938
511b5ee
sfali pushed a commit to sfali/alpakka that referenced this issue Jun 18, 2018
running integration tests, akka#938
8959131 
   * reverting back main docker-compose.yml
   * run s3/docker-compose.yaml with -f option
   * update endpointUrl
@ennru ennru mentioned this issue Jan 14, 2019
Merged
@2m 2m added this to the 1.0-M2 milestone Jan 16, 2019
@2m
Copy link
Member

2m commented Jan 16, 2019

Fixed in #1395

@2m 2m closed this as completed Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p:aws-s3
Projects
None yet
Milestone
1.0-M2
Development

No branches or pull requests
3 participants
@2m @ennru @sfali