Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync google modules jwt-core version #1815

Merged
merged 1 commit into from
Aug 12, 2019
Merged

sync google modules jwt-core version #1815

merged 1 commit into from
Aug 12, 2019

Conversation

francisdb
Copy link
Contributor

fixes #1811 and enable scala 2.13 cross build for all google modules
fixes #1762
fixes #1763

As jwt-core 2 and 3 are not compatible this is a breaking change

to continue the cleanup see #773

@ennru ennru added this to the 2.0.0 milestone Jul 4, 2019
@francisdb
Copy link
Contributor Author

Build failures are unrelated?

@enru What are your thoughts on #773 ? Has this been done before, do you see a need to remove duplication between the three google modules?

@ennru
Copy link
Member

ennru commented Jul 5, 2019

Thank you. I believe independence of the connectors is valuable as well. So I'd leave it as it is for another round.

@ennru
Copy link
Member

ennru commented Aug 9, 2019

master is ready to merge Alpakka 2.0 PRs. Can you rebase this and remove the exclusion in https://github.com/akka/alpakka/blob/master/build.sbt#L77 now that all modules use the same JWT version, please?

@francisdb
Copy link
Contributor Author

@ennru applied, rebased and squashed

@ennru
Copy link
Member

ennru commented Aug 12, 2019

Failure was #1549

Copy link
Member

@ennru ennru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ennru ennru merged commit f0bb958 into akka:master Aug 12, 2019
@ennru
Copy link
Member

ennru commented Aug 12, 2019

Thank you!

@francisdb francisdb deleted the syncjwt branch August 19, 2019 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants