Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix multiple examples for commit after write to elasticsearch #2986

Merged
merged 1 commit into from
Jun 16, 2023
Merged

docs: fix multiple examples for commit after write to elasticsearch #2986

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 3 additions & 9 deletions elasticsearch/src/test/scala/docs/scaladsl/ElasticsearchV5Spec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,9 +241,8 @@ class ElasticsearchV5Spec extends ElasticsearchSpecBase with ElasticsearchSpecUt

"kafka-example - store documents and pass Responses with passThrough in bulk" in {

//#kafka-example
// We're going to pretend we got messages from kafka.
// After we've written them to Elastic, we want
// After we've written them to Elastic in bulk, we want
// to commit the offset to Kafka

case class KafkaOffset(offset: Int)
Expand Down Expand Up @@ -284,7 +283,6 @@ class ElasticsearchV5Spec extends ElasticsearchSpecBase with ElasticsearchSpecUt
.runWith(Sink.ignore)

kafkaToEs.futureValue shouldBe Done
//#kafka-example
flushAndRefresh(connectionSettings, indexName)

// Make sure all messages was committed to kafka
Expand All @@ -295,9 +293,8 @@ class ElasticsearchV5Spec extends ElasticsearchSpecBase with ElasticsearchSpecUt

"kafka-example - store documents and pass Responses with passThrough skipping some w/ NOP" in {

//#kafka-example
// We're going to pretend we got messages from kafka.
// After we've written them to Elastic, we want
// Of those, only some will be written to Elastic, we want
// to commit the offset to Kafka

case class KafkaOffset(offset: Int)
Expand Down Expand Up @@ -343,7 +340,6 @@ class ElasticsearchV5Spec extends ElasticsearchSpecBase with ElasticsearchSpecUt
.runWith(Sink.ignore)

kafkaToEs.futureValue shouldBe Done
//#kafka-example
flushAndRefresh(connectionSettings, indexName)

// Make sure all messages was committed to kafka
Expand All @@ -355,9 +351,8 @@ class ElasticsearchV5Spec extends ElasticsearchSpecBase with ElasticsearchSpecUt

"kafka-example - skip all NOP documents and pass Responses with passThrough" in {

//#kafka-example
// We're going to pretend we got messages from kafka.
// After we've written them to Elastic, we want
// After we skip all NOP docs, we want
// to commit the offset to Kafka

case class KafkaOffset(offset: Int)
Expand Down Expand Up @@ -402,7 +397,6 @@ class ElasticsearchV5Spec extends ElasticsearchSpecBase with ElasticsearchSpecUt
.runWith(Sink.ignore)

kafkaToEs.futureValue shouldBe Done
//#kafka-example
flushAndRefresh(connectionSettings, indexName)

// Make sure all messages was committed to kafka
Expand Down