Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Adds Google cloud storage support #650

Closed
wants to merge 9 commits into from
Closed

WIP - Adds Google cloud storage support #650

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d4a3116
initial commit of googlecloudstorage
francisdb Dec 14, 2017
337bb5b
Do not use Future.unit as only available on scala 2.12
francisdb Dec 14, 2017
b99d9f4
Merge branch 'master' into googlestorage
francisdb Feb 12, 2018
24d4c43
switch to scalatest instead of specs2
francisdb Feb 12, 2018
8cb82a3
switch to scalatest instead of specs2
francisdb Feb 12, 2018
bff645d
switch to spray-json instead of play-json
francisdb Feb 12, 2018
9cc4b85
avoid using relative path in session test
francisdb Feb 12, 2018
7c09196
initial work on scala/java api
francisdb Feb 13, 2018
e2ed22c
avoid using unix-specific paths for testing
francisdb Feb 15, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...le-cloud-storage/src/test/scala/akka/stream/alpakka/googlecloud/storage/SessionSpec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ class SessionSpec extends WordSpec {
"report the path of the missing service account file" in {
implicit val as: ActorSystem = null
implicit val mat: Materializer = null
val session = new Session(GoogleAuthConfiguration("missingpath"), Seq.empty)
val session = new Session(GoogleAuthConfiguration("/missing/path/test.json"), Seq.empty)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this break the build on non unixy machines. Use TempDirectory.location() and then combine with a more specific file name that will not exist.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Switching to Paths.get(System.getProperty("java.io.tmpdir")).resolve("idonotexist.json") as TempDirectory is not accessible

val thrown = intercept[RuntimeException] {
session.getToken()
}
assert(thrown.getMessage === "Service account file missing: /Users/francisdb/workspace/alpakka/missingpath")
assert(thrown.getMessage === "Service account file missing: /missing/path/test.json")
}

}
Expand Down