Report cause for Akka/IO TCP CommandFailed events #6221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ismaelhamed
commented
Nov 1, 2022
| public CommandFailed WithCause(Exception cause) | ||
| { | ||
| // Needs to be added with a mutable property for compatibility reasons | ||
| return new CommandFailed(Cmd) { Cause = cause }; |
There was a problem hiding this comment.
Not sure if this holds true in C# or we could just add a second constructor instead.
There was a problem hiding this comment.
We could just add a constructor overload and that would work
There was a problem hiding this comment.
Although I think this is probably a fine way of doing it
ismaelhamed
force-pushed
the
include-cause-in-command_failed-22954
branch
from
8aa5df2 to
efc6069
Compare
|
@Arkatufus can we backport to v1.4? |
Aaronontheweb
pushed a commit
that referenced
this pull request
Nov 3, 2022
…6224) * Port [#22954](akka/akka#22954) ## Changes > I think we should finally fix this once and forever. We have so many failed test jobs where we cannot be sure why "Connect failed" and we have no way of finding out without enabling DEBUG log level everywhere. That same pain is felt by every user. (cherry-picked from c9c0b44) * Update API Verify list Co-authored-by: Ismael Hamed <1279846+ismaelhamed@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port #22954
Changes
Checklist
For significant changes, please ensure that the following have been completed (delete if not relevant):