remove unused reference.conf from DistributedData.LightningDb
#7294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These configuration values are read from and used by `DistributedData/reference.conf`, so this unused duplicate file is confusing and unnecessary.
Aaronontheweb
added
configuration
akka-ddata
akka-ddata-durable
Aaronontheweb
changed the title
reference.confg from DistributedData.LightningDbreference.conf from DistributedData.LightningDb
|
On this block of code: WithSystem(_configForNewMode, typeName, "NewMode", (system, region, rememberedEntitiesProbe) =>
{
AssertRegionRegistrationComplete(region);
var probe = CreateTestProbe(system);
region.Tell(new Message(1), probe.Ref);
probe.ExpectMsg("ack");
ImmutableHashSet.Create(
rememberedEntitiesProbe.ExpectMsg<string>(),
rememberedEntitiesProbe.ExpectMsg<string>(),
rememberedEntitiesProbe.ExpectMsg<string>()).Should().BeEquivalentTo("1", "2", "3"); // 1-2 from the snapshot, 3 from a replayed message
rememberedEntitiesProbe.ExpectNoMsg();
});The issue occurred because the sharding system had to retry remembering entity All 3 entities get started, but due to the retry to entity 1 the |
Aaronontheweb
commented
Jul 22, 2024
| // due to retries in the remember-entities system, we have to tolerate | ||
| // potentially receiving a duplicate message for the same entity | ||
| // therefore, we need to wait for at least 3 distinct messages or until the timeout | ||
| var maxTimeout = TimeSpan.FromSeconds(5); |
There was a problem hiding this comment.
Hardened the spec here - the comment above explains the change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
These configuration values are read from and used by
DistributedData/reference.conf, so this unused duplicate file is confusing and unnecessary.